-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Body handling for get and delete methods #68
Comments
Any update on this? |
There is a new option being added to v3.0.0 which will be released later today. I will post another comment here which will inform you how to workaround this with the new option, it's pretty simple. However I should inform you that according to https://tools.ietf.org/html/rfc7231 and also https://stackoverflow.com/questions/978061/http-get-with-request-body it is not a standard nor is there a semantic definition for having a payload in
|
Also https://github.com/bitinn/node-fetch/blob/master/src/request.js#L75-L78 |
I've fixed this and it will be released in v3.0.0 later today. |
v3.0.0 is released which fixes this issue 🎉
|
Currently Frisbee converts body into a query string for
get
anddelete
methods. That's weird because it's an artificial limitation and there is no way to workaround it. On the other hand it requires additional tooling to add a query string to an url.I propose to bring
get
anddelete
methods in line with the rest of methods and introduce aparams
option, that will stringify params and add it to url. I would be happy to send PRs!The text was updated successfully, but these errors were encountered: