Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formidable warnings when used with webpack #1609

Closed
byungjuJin opened this issue Dec 4, 2020 · 3 comments
Closed

formidable warnings when used with webpack #1609

byungjuJin opened this issue Dec 4, 2020 · 3 comments

Comments

@byungjuJin
Copy link

byungjuJin commented Dec 4, 2020

in dependencies, superagent use "formidable": "^1.2.2"
And this have a issue with webpack.
For fix it, update need to formidable V2.
It still on canary version but owner recommend use it.
Please check below issue.

node-formidable/formidable#337

Warning: ./node_modules/superagent/node_modules/formidable/lib/incoming_form.js 1:43-50
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
at CommonJsRequireContextDependency.getWarnings ()
@ ./node_modules/superagent/node_modules/formidable/lib/index.js
@ ./node_modules/superagent/lib/node/index.js

@mccart
Copy link

mccart commented Nov 2, 2021

formidable v1 now depreciated and v2 supposed to be backward compatible to v1

@vicb
Copy link

vicb commented Jan 10, 2022

Hey @niftylettuce is this fixed in 7.0.1 ? I see that formidable is now at v2.

If not is there anything I can help with ?

@niftylettuce
Copy link
Collaborator

Yeah it's fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants