Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in IE8 #161

Closed
jescalan opened this issue Dec 10, 2012 · 2 comments
Closed

Does not work in IE8 #161

jescalan opened this issue Dec 10, 2012 · 2 comments

Comments

@jescalan
Copy link

Because in this line reduce is called on an array, and reduce on arrays is not supported before IE9, superagent breaks in IE8 or below. I'm a little surprised this hasn't been filed already, and just realized it is causing disastrous results in a fairly high-visibility app. I'll see if I can get a pull request in the fix this in the next few hours.

More details on IE8 and the array.reduce(): https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Array/Reduce#Browser_compatibility

@jescalan
Copy link
Author

It looks like this has been known since #90 and fixed in #151 - is there any chance we could get this merged in? Although shitty browsers are not fun to develop for, having code break in IE8 really can't happen - it's still very heavily used.

@tj
Copy link
Contributor

tj commented Jan 3, 2013

next release right away will have the reduce component

@tj tj closed this as completed Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants