Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsilence fails if output path is in a new directory #53

Closed
pilattebe opened this issue Nov 23, 2020 · 4 comments
Closed

unsilence fails if output path is in a new directory #53

pilattebe opened this issue Nov 23, 2020 · 4 comments

Comments

@pilattebe
Copy link

Describe the bug
unsilence folder1/input.mp4 folder2/output.mp4 fails if folder2 does not exist.

To Reproduce
Steps to reproduce the behavior:

  1. create folder1/input.mp4
  2. run unsilence folder1/input.mp4 folder2/output.mp4
  3. OSError: Parent directory not found

Expected behavior
It should create folder2.

Desktop (please complete the following information):

  • macOS 11.0.1
  • Python 3.9.0
  • FFMPEG version 4.3.1
@alexkeizer
Copy link

I would argue it is very much standard/expected behaviour for tools like this to only function if the output is in an already existing directory.

Ffmpeg itself, for example, will also fail if you supply it with a path in a non-existent directory

@pilattebe
Copy link
Author

Ok, maybe... I'm not used to this behavior.
Compilers, for example, create /build if it doesn't exist. Same for tools like yarn with /node_modules etc.

@pilattebe
Copy link
Author

Close this issue if it is not to be changed.

@lagmoellertim
Copy link
Owner

I think I leave it like it is, as it seems to be the default way this is handled.
Also, this avoid typos, where you tried to place the output file in an existing folder, but because of the misspelling, you created a new, unwanted folder that you need to deal with later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants