New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for multiple HTTP headers with same field name in ResponseHeader #1000
Comments
At its core I believe this is a Play issue, not a Lagom one. There is some context here: playframework/playframework#3279 This is not really a problem for Play users because Play already has a high-level API to handle cookies, for example: Ok("Hello world").withCookies(Cookie("cookie1", "One"), Cookie("cookie2", "Two")) Lagom has it's own As a workaround, I think it should work to use a single |
I was just about to reply with exactly the same thing. Play unfolds |
Thanks, the solution with a single |
@bmontuelle I will close this issue. Please reopen if you want to discuss further. |
@ignasi35 Thats fine to me, we ended up moving all the cookie management into the web gateway and using play Cookies api for it |
Are you looking for help?
Following up the discussion on glitter channel https://gitter.im/lagom/lagom?at=59bfcc2d7b7d98d30d0d3005
Lagom Version (1.2.x / 1.3.x / etc)
1.4.0-M2
API (Scala / Java / Neither / Both)
Scala
Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)
MacOS
10.12.6 (16G29)
JDK (Oracle 1.8.0_112, OpenJDK 1.8.x, Azul Zing)
Oracle 1.8.0_111
Expected Behavior
Suspected behavior also appears with this definition
set-cookie
headers in the responseActual Behavior
The response HTTP headers only contains one occurence of "set-cookie" header, the first defined.
As RFC 6265 states its required to use multiple occurence of headers with the same field name for
set-cookie
. Others HTTP headers will probably fall in the same case (most notably those fromX-
non-standards headers)The text was updated successfully, but these errors were encountered: