Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OffSet storage need the eventProcessorId #1056

Merged
merged 1 commit into from Oct 24, 2017
Merged

OffSet storage need the eventProcessorId #1056

merged 1 commit into from Oct 24, 2017

Conversation

cheleb
Copy link
Contributor

@cheleb cheleb commented Oct 14, 2017 •
edited

AFAIU

Pull Request Checklist

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

@octonato
Copy link
Member

Hi @cheleb,

Thanks for this contribution. That's indeed correct to say that we are using a compound primary key.

Would you mind to also include the same modification for the java documentation?
https://github.com/lagom/lagom/blob/master/docs/manual/java/guide/cluster/ReadSide.md

Thanks

@cheleb
Copy link
Contributor Author

cheleb commented Oct 24, 2017

Ive juste noticed that Link to 'Offse't is missing in scala doc, should I add a fix in this PR ?

@ignasi35
Copy link
Contributor

I don't think there's a scaladsl equivalent to javadsl's Offset. IIRC that's for historical reasons:

  • when creating the Lagom javadsl, we introduced a layer of abstraction over Akka's Offset.
  • when creating the Lagom scaladsl, Akka's Offset already supported Long and UUID and for that reason we simply reused Akka's implementation.
  • Because Lagom's javadsl already had published an Offset as public API we kept that.

@cheleb
Copy link
Contributor Author

cheleb commented Oct 24, 2017

Thank you @ignasi35 for this explanation.

@octonato octonato merged commit 8a267cb into lagom:master Oct 24, 2017
@TimMoore TimMoore modified the milestones: Lagom 1.4.0, Lagom 1.3.10 Oct 25, 2017
TimMoore pushed a commit that referenced this pull request Oct 25, 2017
@cheleb
OffSet storage need the eventProcessorId (#1056)
74ee2f0
@TimMoore
Copy link
Contributor

Backported: 1.3.x 74ee2f0

mdonkers pushed a commit to mdonkers/lagom that referenced this pull request Nov 11, 2017
Merge branch 'lagom-master'
090fb6b 
* lagom-master: (194 commits)
  Improves error messages in path param serializer resolution (lagom#1093)
  Split test execution for Scala 2.11 and 2.12 (lagom#1095)
  Removed Scala style errors (lagom#1031)
  Setup MiMa for scaladsl projects (lagom#1092)
  Update to Play 2.6.7 (lagom#1088)
  Update Scala 2.12 version to 2.12.4 (lagom#1086)
  Akka Persistence JDBC update (lagom#1077)
  Fix unhandled event issue message in PersistentEntityTestDriver (lagom#1079)
  Delete PersistentEntityTestDriver.runOne (lagom#1081)
  Feature/update docs (lagom#1076)
  Hotfix/jsvalue serialization (lagom#1071)
  PathParamSerializer derived instances for traversables (lagom#1021)
  Ensures .gitignore file is copied to the Maven archetype (lagom#1070)
  Allow subscribers to access message metadata (lagom#1047)
  OffSet storage need the eventProcessorId (lagom#1056)
  Update and synchronize dependency versions (lagom#1061)
  Upgraded akka persistence cassandra version to 0.57 (lagom#1037)
  Added to the persistent read-sides documentation for CassandraReadSide, JdbcReadSide, etc the missing section about registering read-side processors (lagom#1052)
  fixes lagom#1018 - FF issue with websocket binary frames (lagom#1039)
  Service Router actions should use filtered request. (lagom#1030)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
Lagom 1.3.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cheleb @octonato @ignasi35 @TimMoore @marcospereira