enabled timeout when fetch read-side offset #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
commented
Mar 21, 2018
| @@ -38,6 +38,9 @@ db.default { | |||
|
|
|||
| # 5 * number of threads | |||
| maxConnections = 100 | |||
|
|
|||
| # if true, a Mbean for AsyncExecutor will be registered | |||
| registerMbeans = false | |||
There was a problem hiding this comment.
Decide to add it to this PR. This can be useful when debugging slick.
AsyncExecutor provides this option, but we were not using it.
octonato
commented
Mar 21, 2018
| } | ||
| scaladsl.Source | ||
| .fromFuture(futureOffset) | ||
| .initialTimeout(config.offsetTimeout) |
There was a problem hiding this comment.
If futureOffset never completes (because of any underlying bug) that Source will never start and therefore the RestartSource wrapping it will never restart.
The call to initialTimeout make sure that the Source fails if a first element (the offset) is not pushed throught it within the passed offsetTimeout (defaults to 5s)
ignasi35
approved these changes
Mar 21, 2018
|
There seems to be a compile issue. |
ignasi35
pushed a commit
that referenced
this pull request
Mar 21, 2018
* enabled timeout when fetch read-side offset * fixing test compilation
|
Backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that read-side processors don't keep waiting forever when fetching offset.