Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Lagom build description #1495

Open
ignasi35 opened this issue Jul 26, 2018 · 2 comments
Open

Refactor Lagom build description #1495

ignasi35 opened this issue Jul 26, 2018 · 2 comments
Labels

Comments

@ignasi35
Copy link
Contributor

ignasi35 commented Jul 26, 2018

(This is to discuss improvements and link to small PRs)

The build for Lagom itself (build.sbt and projects/*) is quite convoluted code and some basic maintenance can sometimes become a tedious or error-prone task. (see #1493 and #1494 edit and #1497 for example).

It'd be good to have a smaller, cleaner build.sbt by applying some ideas from other builds this size such as Akka and Play:

  1. In Akka, there are custom sbt plugins extending upstream equivalent and overriding the default for Akka's needs.
  2. In Play, there is a collection of factory methods specialised on each type of Project the Play build needs.
@erip
Copy link
Contributor

erip commented Jul 30, 2018

This will be nice for when we enable the SBT 1.x scripted plugin, because it requires non-scripted projects to disable the plugin, which is most of them in the case of lagom.

@ignasi35
Copy link
Contributor Author

related: #1474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants