Unmanaged services registered even when disabled

[ignasi35]

Lagom Version (1.2.x / 1.3.x / etc)

1.5.x

API (Scala / Java / Neither / Both)

Seen it on scala+sbt (this is a build tool issue, actually)

Expected Behavior

If DevMode's Kafka/Cassandra services are disabled, then Service Registry doesn't include information about them.

Actual Behavior

With a simple lagom app that explicitly disables both Kafka and Cassandra in dev mode, when checking http://localhost:9008/services there's info for both kafka_native and cas_native.

Reproducible Test Case

Create a new project using sbt new lagom/lagom-scala.g8, disabled kafka and/or cassandra in build.sbt and check http://localhost:9008/services.

---

I think the problem may be that this code (and probably the same happens in maven Mojos) doesn't check if services are enabled or disabled.

[TimMoore]

I think this was an intentional decision to make it easier to integrate Lagom dev mode with Cassandra and Kafka services that you run yourself. Is there a drawback?

[ignasi35]

In the case of Kafka I think your comment is correct.

In the case of Cassandra, I think the registered service stated cas_native -> tcp://localhost:4000 so it's not immediately usable because 4000 is not Cassandra's default port. Users will have to either tune their external Cassandra settings (which may not be running in localhost or port 4000) or override Lagom's registry.