Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionStageUtils #732

Open
edouardKaiser opened this issue May 8, 2017 · 2 comments
Open

CompletionStageUtils #732

edouardKaiser opened this issue May 8, 2017 · 2 comments

Comments

@edouardKaiser
Copy link
Contributor

In the online-auction example, there is a CompletionStageUtils which contains very useful helpers to manipulates CompletionStage. it might be worth moving this to Lagom itself.

Anyone manipulating CompletionStage ends up writing this exact set of functions.

@jroper
Copy link
Member

jroper commented May 8, 2017

Tell me about it. And trust me, we did do our best to try and influence the CompletionStage API to include these before JDK 8 came out, that would have been the best solution, but unfortunately nothing came of it.

I don't know if these belong in Lagom or not - I'd rather not be responsible for maintaining utility APIs like this, once you add one utility method, then why not add a whole suite of methods? There are dedicated libraries for making up for the short comings of the JDK, such as Guava and commons-lang, it'd be better to add these there and then make everyone depend on one of those.

@edouardKaiser
Copy link
Contributor Author

I understand your point of view, in another project we wrapped the CompletionStage into something more meaningful and useful in terms of API design.

Ultimately it should sit somewhere else, you're right, but you guys are moving faster than any of the big mastodon (Guava, Apache Lang...).

No big deal, I was just curious if you guys thought about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants