Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Dependencies.scala in docs/build.sbt #809

Open
ignasi35 opened this issue Jun 15, 2017 · 5 comments
Open

Reuse Dependencies.scala in docs/build.sbt #809

ignasi35 opened this issue Jun 15, 2017 · 5 comments

Comments

@ignasi35
Copy link
Contributor

The sbt build for docs uses the root build.sbt but it uses it's own set of versions for the depending libraries.

docs/build.sbt should use project/Dependencies.scala as much as possible.

Alternatively, docs approach should be reconsidered so instead of being a super-project (separate sbt that imports root/build.sbt) it is part of root or ... (other options)

@octonato
Copy link
Member

+1 for making is part of root, but I have no idea why it was made like that.

One of the advantages of having it under root is that contributors can immediately spot when something get broken inside the docs. It's kind of hidden as it is currently configured.

@erip
Copy link
Contributor

erip commented Jun 27, 2017

If I'm understanding correctly, the proposal here is to remove docs/build.sbt and merge it into the root build.sbt while reusing the Dependencies.scala values as much as possible.

Is this correct?

Update: doing some initial work on this and I got an OutOfMemoryError when sbt was fetching dependencies. 😮

@TimMoore
Copy link
Contributor

That's the basic idea, @erip, but I think there are some unknown complexities in making this work. For one thing, I know that parts of the docs build rely on the Lagom sbt plugin, and my understanding is that you can't build and then use an sbt plugin in the same build.

The OutOfMemoryError might just mean that you need to increase the maximum heap size. It's a big beast 😄

@erip
Copy link
Contributor

erip commented Jun 28, 2017

I'll bang away at it. I have some very strawman commits in the pipeline currently, but it'll require a more thorough attempt... 😄

@erip
Copy link
Contributor

erip commented Jul 2, 2017

@TimMoore You seem to be correct here. It seems like in the interim, the issue as-is can be solved fairly trivially by just reusing the root dependencies versions.

It seems like a natural commit to create xVersions for all common dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants