Strongly type the Lagom service router #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroper
force-pushed
the
typed-service-router
branch
from
127d25f
to
3a546c4
Compare
octonato
reviewed
Jul 18, 2017
| /** | ||
| * A Lagom service router. | ||
| * | ||
| * This trait doesn't add anything, except that it makes the router created by the LagomServer |
There was a problem hiding this comment.
Maybe better to use the term "interface" instead of "trait" here as the target audience are java developers
jroper
force-pushed
the
typed-service-router
branch
2 times, most recently
from
64a76d8
to
ab31e15
Compare
If you want to use a custom router that delegates to the Lagom router, or in my case, if you're writing a Play app but you want to embed a Lagom service implementation into it, then in order to take advantage of type based dependency injection, you need to be able to refer to the Lagom service router by type. This introduces a type for the Lagom service router in both the Java and Scala APIs, so that they can be injected by type into another Play router.
jroper
force-pushed
the
typed-service-router
branch
from
ab31e15
to
78a4a3d
Compare
|
@jroper do you want this in 1.3.7? |
TimMoore
approved these changes
Jul 20, 2017
octonato
pushed a commit
to octonato/lagom
that referenced
this pull request
Jul 20, 2017
If you want to use a custom router that delegates to the Lagom router, or in my case, if you're writing a Play app but you want to embed a Lagom service implementation into it, then in order to take advantage of type based dependency injection, you need to be able to refer to the Lagom service router by type. This introduces a type for the Lagom service router in both the Java and Scala APIs, so that they can be injected by type into another Play router.
|
Backported in 1.3.x (a6bedc7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use a custom router that delegates to the Lagom router, or in my case, if you're writing a Play app but you want to embed a Lagom service implementation into it, then in order to take advantage of type based dependency injection, you need to be able to refer to the Lagom service router by type. This introduces a type for the Lagom service router in both the Java and Scala APIs, so that they can be injected by type into another Play router.