Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL implementation #430

Open
QuiiBz opened this issue Dec 28, 2022 · 4 comments
Open

Improve URL implementation #430

QuiiBz opened this issue Dec 28, 2022 · 4 comments

Comments

@QuiiBz
Copy link
Member

QuiiBz commented Dec 28, 2022

The current URL implementation is fairly simple and isn't very compliant with the spec:

cd crates/wpt-runner && cargo run -- ../../tools/wpt/url/
...
449 tests, 38 passed, 410 failed
 -> 8% conformance

Most of the failing tests are located in urlencoded-parser.any.js (102 tests, 90 fails) and url-setters-stripping.any.js (260 tests, 260 fails)

@QuiiBz QuiiBz added this to the Alpha milestone Dec 28, 2022
@QuiiBz QuiiBz changed the title Fix URL implementation Improve URL implementation Jan 28, 2023
@QuiiBz QuiiBz modified the milestones: Alpha, Beta Feb 12, 2023
@20k-ultra
Copy link
Contributor

How can I run these tests to try and work on this issue ? Is it resolved ?

I hoped to confirm myself by trying the following but got an error:

$ cd crates/wpt-runner && cargo run -- ../../tools/wpt/url
   Compiling lagon-runtime-isolate v0.1.0 (/home/mig/Projects/lagon/crates/runtime_isolate)
error: couldn't read crates/runtime_isolate/src/../runtime.js: No such file or directory (os error 2)
 --> crates/runtime_isolate/src/options.rs:6:26
  |
6 | const JS_RUNTIME: &str = include_str!("../runtime.js");
  |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the macro `include_str` (in Nightly builds, run with -Z macro-backtrace for more info)

I used crates/wpt-runner since packages/wpt-runner is gone

@QuiiBz
Copy link
Member Author

QuiiBz commented Mar 8, 2023

You have to build packages/js-runtime first: pnpm install && cd packages/js-runtime && pnpm build

The contributing docs need to be updated.

@20k-ultra
Copy link
Contributor

I'll PR the docs with my notes from getting the project setup

@QuiiBz
Copy link
Member Author

QuiiBz commented Jun 3, 2023

After #835, we now have the following results:

197 tests, 130 passed, 67 failed (0 not completed)
 -> 65% conformance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants