Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for need_destroy #39

Open
laixintao opened this issue Dec 7, 2021 · 3 comments
Open

tests for need_destroy #39

laixintao opened this issue Dec 7, 2021 · 3 comments

Comments

@laixintao
Copy link
Collaborator

somehow some of my instance didn't get destroyed, I suspect there are some bugs in

def need_destroy(cls, provider: BaseProvider, meta: LBServerMeta) -> Tuple[bool, str]:

but I didn't find any, let me add test cases later.

@luxiaba
Copy link
Collaborator

luxiaba commented Dec 7, 2021

seems killers don't work as expected sometimes, it happened to me before, but i don't remember clearly.

i think i can check it tomorrow. which kind of host do you use, remote vps or local container?

@laixintao
Copy link
Collaborator Author

local container, but I think that doesn't matter because the logs said this instance should have more time to live, which it doesn't.

@luxiaba
Copy link
Collaborator

luxiaba commented Dec 8, 2021

got it, i'll check it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants