UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 4093-4094: unexpected end of data

[messense]

CRI [20211208-07:42:34.995] thr=140672309044992 lobbyboy.socket_handle:254: *** Socket thread error.                                                                                                                                                                                                                          Traceback (most recent call last):
  File "/root/code/lobbyboy/lobbyboy/socket_handle.py", line 247, in run
    self.user_using(server, proxy_subprocess)
  File "/root/code/lobbyboy/lobbyboy/socket_handle.py", line 188, in user_using
    send_to_channel(self.channel, os.read(master_fd, 10240).decode(), suffix="")
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 4093-4094: unexpected end of data
DEB [20211208-07:42:35.003] thr=140672300570368 paramiko.transport:1819: EOF in transport thread

[messense]

lobbyboy/lobbyboy/utils.py

Lines 86 to 89 in 96079a8

	def send_to_channel(channel: Channel, msg: str = "", prefix: str = "", suffix: str = "\r\n"):
	if isinstance(msg, bytes):
	msg = msg.decode()
	channel.send(f"{prefix or ''}{msg}{suffix or ''}".encode())

decode and encode again...that's a mess.

[luxiaba]

yes it was a bit. in order to be compatible with others at that time, i'll check and unify soon, thank you for pointing this out.

[messense]

BTW, I think using channel.send is wrong since it doesn't guarantee that the buffer will be sent fully, sendall should be used instead. It's a common mistake in networking code.

Applications are responsible for checking that all data has been sent: if only some of the data was transmitted, the application needs to attempt delivery of the remaining data.

[luxiaba]

seems channel.sendall is right, @laixintao what do you think?

[laixintao]

Yes, should use channel.sendall (my bad).