Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be a flag for critical EAD? #312

Closed
emanjon opened this issue Jun 29, 2022 · 6 comments
Closed

Should there be a flag for critical EAD? #312

emanjon opened this issue Jun 29, 2022 · 6 comments
Labels

Comments

@emanjon
Copy link
Collaborator

emanjon commented Jun 29, 2022

There is a new PR #311 suggesting this. There is no background discussion in the PR #311. There would be good with some use case.

The definition of what critical need and how the recipient handles critical would need a lot of discussion and fine-tuning.The handling of critical extensions in C.509 is to my understanding confusing and problematic. Both in the specification and in implementations.

@gselander
Copy link
Collaborator

Please see #275 for background discussion and use cases.

@emanjon
Copy link
Collaborator Author

emanjon commented Jun 30, 2022

Seems very unclear that the current PR can be the basis for a ECH type mechanism. PR #311 should motivate why it is the basis for an ECH type mechanism or we should have some discussion regarding use cases for a general critical non-critical EAD mechanism. I do not see that #311 follow from #275.

@emanjon
Copy link
Collaborator Author

emanjon commented Jun 30, 2022

Having critical/non-critical EAD seems like a reasonable thing in its own, but it is not clear to me that it is a step on the way to a ECH mechanism in EDHOC.

@gselander
Copy link
Collaborator

Should we add another column in IANA register?

Type: always critical / always non-critical / application determines criticality

@gselander
Copy link
Collaborator

If we define such a Type, the following text can be removed from specification and replaced by IANA consideration:

"A specification registring a new EAD label MUST describe if the EAD item is always critical, always non-critical, or if it can be decided by the application in the sending endpoint."

@gselander
Copy link
Collaborator

I merged #311 which addresses some points raised in this issue. Please review and comment if there is anything missing.

The consequences of EDHOC processing of critical / non-critical EAD items is described, but how the security application makes use of this property is left to the associated specification. (In particular, no registration of criticality in the IANA register.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants