Playaround with cyclomatic complexity.

damax-solutions · Aug 30, 2018 · 4602a4e · 4602a4e
1 parent 68800be
commit 4602a4e
Showing 1 changed file with 16 additions and 15 deletions.
diff --git a/src/Bridge/Symfony/Console/Command/RosfinLookupCommand.php b/src/Bridge/Symfony/Console/Command/RosfinLookupCommand.php
@@ -56,23 +56,24 @@ protected function execute(InputInterface $input, OutputInterface $output)
             return 0;
         }
 
-        $format = function (RosfinItem $terrorist): array {
-            return [
-                ['ID', $terrorist->id()],
-                ['Type', $terrorist->type()],
-                ['Full name', implode("\n", $terrorist->fullName())],
-                ['Birth date', $terrorist->birthDate() ?: '-'],
-                ['Birth place', $terrorist->birthPlace() ?: '-'],
-                ['Description', $terrorist->description() ? mb_substr($terrorist->description(), 0, 120) : '-'],
-                ['Address', $terrorist->address() ?: '-'],
-                ['Resolution', $terrorist->resolution() ?: '-'],
-                ['Passport', $terrorist->passport() ?: '-'],
-            ];
-        };
-
         foreach ($check as $item) {
             $io->newLine();
-            $io->table(['Field', 'Value'], $format($item));
+            $io->table(['Field', 'Value'], $this->formatItem($item));
         }
     }
+
+    private function formatItem(RosfinItem $terrorist): array
+    {
+        return [
+            ['ID', $terrorist->id()],
+            ['Type', $terrorist->type()],
+            ['Full name', implode("\n", $terrorist->fullName())],
+            ['Birth date', $terrorist->birthDate() ?: '-'],
+            ['Birth place', $terrorist->birthPlace() ?: '-'],
+            ['Description', $terrorist->description() ? mb_substr($terrorist->description(), 0, 120) : '-'],
+            ['Address', $terrorist->address() ?: '-'],
+            ['Resolution', $terrorist->resolution() ?: '-'],
+            ['Passport', $terrorist->passport() ?: '-'],
+        ];
+    }
 }