Formatting, compatibility, and simplification #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few formatting inconsistencies like indention or using grave instead $() for command substitution. All information is now kept in a single file $HOME/.water. The first line is the true/false, the second is the unix timestamp. Replaced all conditionals with POSIX style statements. This should make it compatible with more POSIX shells. The WATER_TIME variable will take an already defined value and fallback to the default of 10800. This allows a user to set the variable outside of the script and not have to mess with it at all. The .water file will be made automatically if it doesn't exist. The first time I ran it, I got an err from cat because the file didn't exist yet. That will no longer be the case.
|
This is great! Tried and tested, it works well. Also, I just found out that I had put the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the commits say, I fixed some formatting inconsistencies and converted the if statements to a more standard syntax. This should mean it's compatible with more than just Bash and zsh but I haven't test yet. I also consolidated the two dot files into one. And, a test file! All the test does is override the water time and run the functions. There's no checking it just runs to manually make sure the results look correct.