Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all shouldn't depend on the clean target #23

Closed
aearil opened this issue Oct 28, 2020 · 1 comment
Closed

make all shouldn't depend on the clean target #23

aearil opened this issue Oct 28, 2020 · 1 comment

Comments

@aearil
Copy link
Contributor

aearil commented Oct 28, 2020

Right now, when you call make, the build environment spends a few minutes chugging along, compiling everything, and in the end you're left back where you started because all the build artefacts were removed by the clean target.

Usually, one expects that calling make will at least result in a usable binary, something like make build in your makefile.

In the Makefile, I would replace all: build release clean by all: build.

@Lallassu
Copy link
Owner

Good catch, I didn't see that myself, usually run make run and then make release.

Thanks, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants