Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddiff/diff hangs on nil #6

Closed
pithyless opened this issue Mar 12, 2019 · 2 comments
Closed

ddiff/diff hangs on nil #6

pithyless opened this issue Mar 12, 2019 · 2 comments

Comments

@pithyless
Copy link

Hi :) I tracked down a weird hanging issue to deep-diff/diff. A minimal repro case:

❯ clj -Sdeps '{:deps {lambdaisland/deep-diff {:mvn/version "0.0-25"}}}'
Clojure 1.10.0
user=> (require '[lambdaisland.deep-diff :as ddiff])

user=> user=> (ddiff/diff {:foo :bar} {:foo :bar})
{:foo :bar}

user=> (ddiff/diff {:foo :bar} {nil :wat :foo :bar})
{:foo :bar, #lambdaisland.deep_diff.diff.Insertion{:+ nil} :wat}

user=> (ddiff/diff {nil :wat :foo :bar} {:foo :bar})
;;;; Here we just hang; probably falling into an infinite loop/recur?
@pithyless
Copy link
Author

pithyless commented Mar 18, 2019

Turns out this was a bug in clj-diff and has been fixed as of: tech.droit/clj-diff {:mvn/version "1.0.1"}

@plexus - can you bump the dependency and cut a new release?

@plexus
Copy link
Member

plexus commented Mar 19, 2019

Released in 0.0-29

@plexus plexus closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants