This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Support Django 1.11 beta #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
force-pushed
the
support-django111
branch
from
f1fff24
to
6ca3372
Compare
giginet
force-pushed
the
support-django111
branch
from
6ca3372
to
ec63d17
Compare
|
@lambdalisue Please Review 🙏 |
lambdalisue
suggested changes
Mar 19, 2017
src/permission/compat.py
Outdated
| @@ -26,6 +26,19 @@ def isiterable(x): | |||
| except ImportError: | |||
| from django.utils.importlib import import_module | |||
|
|
|||
| if django.VERSION >= (1, 11): | |||
There was a problem hiding this comment.
The is_authenticated and is_anonymous has become attributes from Django 1.10 (internally, it is a property which returns a callable boolean for backward compatibility ref)
So the line should be the following even if the method style is supported in Django 1.10
if django.VERSION >= (1, 10):
src/permission/compat.py
Outdated
| @@ -26,6 +26,19 @@ def isiterable(x): | |||
| except ImportError: | |||
| from django.utils.importlib import import_module | |||
|
|
|||
| if django.VERSION >= (1, 11): | |||
There was a problem hiding this comment.
The unusual condition should be in a IF block. I meant the code should be
if django.VERSION < (1, 10):
# For backward compatibility
...
else:
# This is a default way
...
src/permission/compat.py
Outdated
| @@ -26,6 +26,19 @@ def isiterable(x): | |||
| except ImportError: | |||
| from django.utils.importlib import import_module | |||
|
|
|||
| if django.VERSION >= (1, 11): | |||
| def is_authenticated(u): | |||
| return u.is_authenticated | |||
There was a problem hiding this comment.
Please use user or user_obj instead of u.
lambdalisue
approved these changes
Mar 19, 2017
|
Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #70 closes #71