Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce separate syntax group for leader symbol #464

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

brandon1024
Copy link
Contributor

Prior to this revision, the leading symbols of a branch or leaf node inherited the highlight group from the branch or leaf symbol, which doesn't look appealing when they are assigned different highlight groups.

This revision introduces a new syntax group FernLeaderSymbol which may be highlighted separately from the node symbols. Documentation is updated accordingly.

The screenshot below demonstrates a before and after.

image

Fixes #461

Prior to this revision, the leading symbols of a branch or leaf node
inherited the highlight group from the branch or leaf symbol, which
doesn't look appealing when they are assigned different highlight
groups.

This revision introduces a new syntax group FernLeaderSymbol which may
be highlighted separately from the node symbols. Documentation is
updated accordingly.
@bluz71
Copy link

bluz71 commented Jan 28, 2023

Just tested, this works perfect.

New highlight group is very nice for theme authors (such as myself) to separately style: indent-guides (leader, the new group), leaf-file-prefix (leaf) and directory-nodes (branch).

Excellent work @brandon1024, hopefully @lambdalisue approves.

@brandon1024
Copy link
Contributor Author

Thanks for testing it out @bluz71, I appreciate it :-)

Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for late reply. LGTM.

@lambdalisue lambdalisue merged commit 1856f03 into lambdalisue:main Feb 8, 2023
@brandon1024 brandon1024 deleted the syntax-leader branch February 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] New 'FernLeadingText' highlight group
3 participants