Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths on Windows #68

Merged
merged 1 commit into from Feb 6, 2020
Merged

Fix paths on Windows #68

merged 1 commit into from Feb 6, 2020

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Feb 5, 2020

"C:" is not a root directory.

@mattn
Fix paths on Windows
48df77b 
"C:" is not a root directory.
@lambdalisue
Copy link
Owner

Close #69

lambdalisue
lambdalisue approved these changes Feb 6, 2020
View reviewed changes
Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite contextual and I'll forget this so I'll probably make wrapper functions of s:Path which care this later. But for now, it 💯 thank you 👍

@lambdalisue lambdalisue merged commit fdc0bbc into lambdalisue:master Feb 6, 2020
@lambdalisue lambdalisue mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdalisue lambdalisue lambdalisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattn @lambdalisue