-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #14, use json to store icons #15
Conversation
Some test failed. Why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split and organize your commit logically so that I can review the changes.
I'm sorry I thought multiple things are in one commit because PR describe several things but it seems things are quite small and can be put into a single commit. I'll review the changes.
Never mind. It seems the failure is not caused by this PR but caused by GitHub macOS runner chage. I'll fix it |
According to https://github.com/ogham/exa/blob/master/src/output/icons.rs add some icons Sort all json alphabetically Remove 'scriptencoding utf-8' because now vim script don't contain icons Add '\m' to avoid pattern match failure because users change their '&magic' Because neovim/neovim#20757 Use '.' to replace '' to get default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Released. https://github.com/lambdalisue/nerdfont.vim/releases/tag/v1.4.0 Thanks for your contribution 🎉 |
You are welcome. I still have some advice: Now the json is sorted alphabetically. If you think |
I also worry about that. Could you add such CI and send me a PR? (I'll do otherwise but it would take time) |
I'll take a try. |
According to https://github.com/ogham/exa/blob/master/src/output/icons.rs
add some icons
sort all json alphabetically
Because neovim/neovim#20757
Use '.' to replace '' to get default value
And, add icons for some directory, like exa: