Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emojipacks fails after the most recent slack update #158

Open
101shipit opened this issue Aug 28, 2018 · 18 comments
Open

emojipacks fails after the most recent slack update #158

101shipit opened this issue Aug 28, 2018 · 18 comments

Comments

@101shipit
Copy link

Slack has update the web UI for the emojis page, and now emojipacks now fails with the following.

Starting import
Got tokens
Logged in
Uh oh! Error: Login error: could not get emoji upload crumb for https://yourteam.slack.com
(node:12714) UnhandledPromiseRejectionWarning: Error: Login error: could not get emoji upload crumb for https://yourteam.slack.com
    at Slack.emoji (/Users/dc/Documents/src/emojipacks/lib/slack.js:162:34)
    at Slack.emoji.next (<anonymous>)
    at onFulfilled (/Users/dc/Documents/src/emojipacks/node_modules/co/index.js:65:19)
    at process._tickCallback (internal/process/next_tick.js:178:7)
(node:12714) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:12714) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@Ruegen
Copy link

Ruegen commented Aug 28, 2018

same error

@kazuuuutaka
Copy link

occur same error

@SatyrTrickster
Copy link

Same error

@camwhite
Copy link

camwhite commented Sep 7, 2018

In my opinion this module needs to be rewritten using puppeteer because Slack has added a modal you must click through.

@itslenny
Copy link

itslenny commented Sep 11, 2018

@camwhite On it... Slapped this together in a few hours. It's worked well for me so far.

https://github.com/itslenny/slack-emoji-import

@camwhite
Copy link

Lol they could only stop bulk uploads for less than a week! Good job @itslenny !!!!

@jackellenberger
Copy link
Contributor

@camwhite no need for puppeteer, they actually added emoji uploads to the proper api (albeit undocumented), so all you need is a user token. No client crumb or cookie needed so no need to interact with the browser!

@jackellenberger
Copy link
Contributor

@lambtron this can be closed with #155 !

@ghost
Copy link

ghost commented Oct 18, 2018

@jackellenberger it seems emojipacks still doesn't work - i tried cloning straight from your fork too.

Uh oh! Error: Application Error: unable to find api token on login page
(node:14149) UnhandledPromiseRejectionWarning: Error: Application Error: unable to find api token on login page
    at Slack.login (/Users/michaelmidura/Development/emojipacks/lib/slack.js:156:13)
    at Slack.login.next (<anonymous>)
    at onFulfilled (/Users/michaelmidura/Development/emojipacks/node_modules/co/index.js:65:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:14149) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

@jackellenberger
Copy link
Contributor

@michaelwm I can't reproduce, are you sure you're specifying the correct creds?

I've moved most of my emoji-development time to emojme which does a few more things than emojipacks, but doesn't come with any packs of its own.

@bronek89
Copy link

Hi!
It seems that on npm is version without this fix:
https://www.npmjs.com/package/emojipacks (last release about year ago)

@gzurbach
Copy link

I confirm that cloning the repo solves the issue. Would be great if the latest was published to npm though.

@itsamayo
Copy link

itsamayo commented Mar 5, 2019

@jackellenberger it seems emojipacks still doesn't work - i tried cloning straight from your fork too.

Uh oh! Error: Application Error: unable to find api token on login page
(node:14149) UnhandledPromiseRejectionWarning: Error: Application Error: unable to find api token on login page
    at Slack.login (/Users/michaelmidura/Development/emojipacks/lib/slack.js:156:13)
    at Slack.login.next (<anonymous>)
    at onFulfilled (/Users/michaelmidura/Development/emojipacks/node_modules/co/index.js:65:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:14149) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

Also getting this error with correct creds

@jackellenberger
Copy link
Contributor

Hey @AshKetchumza, this is actually a different problem then what was happening before; Slack recently updated their pages to not use a long configuration string that was regex'd into, but as of yesterday they use a nice lil JSON.

That file, /lib/slack.js, will need an update for the login to work again.

@xlogix
Copy link

xlogix commented Mar 20, 2020

+1 Still having this error in 2020

@davidkhardwick
Copy link

+1 same

@emeria
Copy link

emeria commented Jun 2, 2021

Anyone find a fix for this?

@andrewmwilson
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests