Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please default to showing sha256 hashes #27

Closed
vagrantc opened this issue Oct 25, 2017 · 7 comments
Closed

please default to showing sha256 hashes #27

vagrantc opened this issue Oct 25, 2017 · 7 comments
Assignees

Comments

@vagrantc
Copy link

Currently, it looks like buildinfo.debian.net defaults to exposing sha1 hashes:

https://buildinfo.debian.net/f5c517c5f165b048b70158666f98ecf42cefb0f0/u-boot_2017.09+dfsg1-3_armhf

But it would be nicer to display sha256, which I think is the strongest hash that dpkg-buildpackage generates by default, is what is exposed in the Packages files in the debian.org package archives.

Thanks!

@lamby
Copy link
Owner

lamby commented Oct 25, 2017

Hi @vagrantc

On https://buildinfo.debian.net/f5c517c5f165b048b70158666f98ecf42cefb0f0/u-boot_2017.09+dfsg1-3_armhf I see the SHA256. Could you clarify where you are missing the SHA256? :)

@vagrantc
Copy link
Author

When I go to the URL:

https://buildinfo.debian.net/f5c517c5f165b048b70158666f98ecf42cefb0f0/u-boot_2017.09+dfsg1-3_armhf

I only see references to SHA1 on that page:

buildinfo.d.n-sha1-only.pdf

It displays the "SHA1 of buildinfo" and only SHA1 for all of the various binary artifacts.

If I go to: https://buildinfo.debian.net/f5c517c5f165b048b70158666f98ecf42cefb0f0/u-boot_2017.09+dfsg1-3_armhf.buildinfo

I of course see Checksums-Md5, Checksums-Sha1 and Checksums-Sha256, as it appears to be displaying the actual .buildinfo file or file contents.

@lamby
Copy link
Owner

lamby commented Oct 26, 2017

I only see references to SHA1 on that page:

Oh, somewhat hiliarously you need a wider screen resolution to see that by default. I think it was looking very ugly for me. If you dig into the HTML source you can see it's doing some magic...

Anyway, will fix...

@vagrantc
Copy link
Author

vagrantc commented Oct 26, 2017

hah! I decreased the font size a bit and it showed up. Ok, that makes some sense, although my screen size isn't exactly small (1920x1080).

I'm not sure it's worth displaying the sha1 at all if the sha256 is available.

@h01ger
Copy link

h01ger commented Oct 26, 2017

yeah, drop sha1…

@lamby
Copy link
Owner

lamby commented Oct 26, 2017

yeah, drop sha1…

FYI dropping sha1 in buildinfo.debian.net is a somewhat separate issue - it's currently used internally as the quality operator between files. Can be changed, but a different issue to this one which is AUIU "just" a presentation issue (which is totally valid).

@h01ger
Copy link

h01ger commented Oct 26, 2017 via email

@lamby lamby closed this as completed in 4a20356 Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants