Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate testnet networks to testnet flag #168

Closed
trojkat opened this issue Apr 16, 2018 · 0 comments
Closed

Migrate testnet networks to testnet flag #168

trojkat opened this issue Apr 16, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request QA done task checked by QA

Comments

@trojkat
Copy link
Contributor

trojkat commented Apr 16, 2018

Right now testnet is a network with test- prefix in name.

    def is_test_network(cls):
        return cls.name and cls.name.startswith('test-')

But we want to determine that by a strict flag instead of a name. Implement flag testnet = True for those networks and remove name field.

@trojkat trojkat added the enhancement New feature or request label Apr 16, 2018
@jaworows jaworows self-assigned this Apr 16, 2018
jaworows added a commit that referenced this issue Apr 17, 2018
…o-test-flag

[#168] Migrate testnet networks to testnet flag
@patrycjanowak patrycjanowak self-assigned this Apr 18, 2018
@patrycjanowak patrycjanowak added the QA done task checked by QA label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QA done task checked by QA
Projects
None yet
Development

No branches or pull requests

3 participants