-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boot parameter is silently ignored for Poisson glm, and summary yields an error #13
Comments
You are right. We haven't implemented bootstrap for Poisson models yet. I will do it soon. |
Not a problem of course! Just mentioning it here since it is perhaps not so clear to users what is going on when this fails. |
Is the bootstrap for Poisson models still in the plan? It would be a great help for evaluating these models! |
Was bootstrapping ever done for these models? I'm using the bootstrap for normal phylolm and it'd be great to plot model results alongside with same method. Or is it easy to code up from inspecting the function? |
Coding bootstrap for Poisson glm is straightforward. All you need is a function to simulate from the Poisson model (similar to the rTrait/rbinTrait functions). Then, you can integrate it into phyloglm just like the boostraps for logistic regression. I've got a lot on my plate, so I couldn't do it right now. Please do a pull request if you code up something and would like to add them to our package. |
From the help, but with Poisson:
phyloglm
doesn't do anything with the bootstrapping for Poisson models, but does run the model normally. Asking for thesummary
then returns an error fromprint.summary.phyloglm
:presumably since it is looking for bootstrap results that aren't actually there.
The text was updated successfully, but these errors were encountered: