Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 support #26

Closed
6 tasks
boesing opened this issue Oct 4, 2020 · 4 comments · Fixed by #31
Closed
6 tasks

PHP 8.0 support #26

boesing opened this issue Oct 4, 2020 · 4 comments · Fixed by #31
Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com Help Wanted
Projects

Comments

@boesing
Copy link
Member

boesing commented Oct 4, 2020

Feature Request

Q A
New Feature yes

Summary

To be prepared for the december release of PHP 8.0, this repository has some additional TODOs to be tested against the new major version.

In order to make this repository compatible, one has to follow these steps:

  • Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
  • Modify composer.json to drop support for PHP less than 7.3
  • Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
  • Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-reqs to COMPOSER_ARGS env variable)
  • Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
  • Modify source code in case there are incompatibilities with PHP 8.0
@boesing boesing added Help Wanted Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 4, 2020
@boesing boesing added this to To do in PHP 8.0 via automation Oct 4, 2020
@stojanovicdusan
Copy link

It is not possible to do it until all other required dependency is updated to PHP 8.0.

@boesing
Copy link
Member Author

boesing commented Mar 13, 2021

Not 100% sure but PHP 8 has --ignore-platform-req=php set in github action.
Bit I dont think that this package is already migrated to GHA.

@weierophinney Do we have ignore platform req enabled?

@boesing
Copy link
Member Author

boesing commented Mar 13, 2021

Yup, here you go https://github.com/laminas/laminas-continuous-integration-action/blob/92f18a56222df7f3d1896de178b6c0531c1af5a0/entrypoint.sh#L82

Thus, you can still create a PR which supports PHP 8.0 for this specific package. No need to have the whole dependency tree verified just to see if there are TODOs in this package.

@boesing
Copy link
Member Author

boesing commented Mar 13, 2021

@stojanovicdusan I've prepared this repository so you can create a PR for PHP 8.0 with the instructions in this issue 👍🏼

@boesing boesing linked a pull request Mar 14, 2021 that will close this issue
@froschdesign froschdesign moved this from To do to In progress in PHP 8.0 Jun 11, 2021
PHP 8.0 automation moved this from In progress to Done Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com Help Wanted
Projects
No open projects
PHP 8.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants