Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.1 #53

Merged
merged 1 commit into from Jun 8, 2022
Merged

Allow PHP 8.1 #53

merged 1 commit into from Jun 8, 2022

Conversation

snapshotpl
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Allow install on PHP 8.1

@snapshotpl snapshotpl added the Enhancement New feature or request label Jun 7, 2022
@snapshotpl snapshotpl added this to the 1.8.0 milestone Jun 7, 2022
@snapshotpl snapshotpl added this to In progress in PHP 8.1 via automation Jun 7, 2022
@snapshotpl snapshotpl force-pushed the php-8.1 branch 2 times, most recently from d52d50d to 34ca53d Compare June 7, 2022 14:20
@calvarezm70
Copy link

You need to update these other packages to make it work on php 8.1

     "laminas-api-tools/api-tools-admin": "^2.0.1",
     "laminas/laminas-developer-tools": "^2.3.0",
     "laminas/laminas-test": "^4.0",

@snapshotpl snapshotpl requested a review from Ocramius June 8, 2022 08:31
@Ocramius
Copy link
Member

Ocramius commented Jun 8, 2022

@snapshotpl I can haz squash?

@snapshotpl
Allow PHP 8.1
53bb2c0 
Signed-off-by: Witold Wasiczko <witold@wasiczko.pl>
@snapshotpl
Copy link
Member Author

@Ocramius done

Ocramius
Ocramius approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snapshotpl!

@Ocramius Ocramius self-assigned this Jun 8, 2022
@Ocramius Ocramius merged commit 0c63fe1 into laminas-api-tools:1.8.x Jun 8, 2022
PHP 8.1 automation moved this from In progress to Done Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement New feature or request
Projects
PHP 8.1
Done
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snapshotpl @calvarezm70 @Ocramius