Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: Adapter is incompatible with IteratorAggregate::getIterator #11

Closed
boesing opened this issue Jul 22, 2021 · 1 comment · Fixed by #13
Closed

PHP 8.1: Adapter is incompatible with IteratorAggregate::getIterator #11

boesing opened this issue Jul 22, 2021 · 1 comment · Fixed by #13
Labels
Bug Something isn't working
Projects

Comments

@boesing
Copy link
Member

boesing commented Jul 22, 2021

Bug Report

Q A
Version(s) latest

Summary

PHP Fatal error:  During inheritance of IteratorAggregate: Uncaught Return type of Adapter::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Current behavior

Tests are failing.

How to reproduce

Execute tests with PHP 8.1

Expected behavior

Tests are passing.

@boesing boesing added the Bug Something isn't working label Jul 22, 2021
@boesing boesing added this to To Do in PHP 8.1 via automation Jul 22, 2021
@boesing boesing linked a pull request Sep 26, 2021 that will close this issue
@boesing
Copy link
Member Author

boesing commented Sep 26, 2021

Closed with #13

@boesing boesing closed this as completed Sep 26, 2021
PHP 8.1 automation moved this from To Do to Done Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
No open projects
PHP 8.1
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant