Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify .laminas-ci.json #54

Open
boesing opened this issue Sep 12, 2021 · 1 comment
Open

Simplify .laminas-ci.json #54

boesing opened this issue Sep 12, 2021 · 1 comment
Labels
BC Break Enhancement RFC Request for Comment; proposal for major new feature or changes.

Comments

@boesing
Copy link
Member

boesing commented Sep 12, 2021

Feature Request

Q A
New Feature yes
RFC yes
BC Break yes

Summary

The .laminas-ci.json allows to pass checks which overrides the additional_checks and thus are mutually exclusive. This makes the JSON schema more bloated as we have to provide two configuration combinations with either checks or additional_checks.

The .checks[].job element has is allowed to be a string which also makes it more error-prone.
It also states that it is possible to select an additional "action" which can be used with the CI matrix which is actually not really true as if someone choses another "action", that action also have to parse the job JSON-string and from this perspective, I dont really see the benefit of having checks.

Due to the fact that .checks[].job is a string, it also cannot be validated by the JSON schema which is feature-requested in #49.

Is there any project around which uses the .checks functionality from .laminas-ci.json? If not, I would prefer getting rid of that to simplify the matrix action.

@boesing boesing added BC Break Enhancement RFC Request for Comment; proposal for major new feature or changes. labels Sep 12, 2021
@boesing
Copy link
Member Author

boesing commented Mar 25, 2022

Will get easier with #83 #95 in case we implement JSON schema generation from typescript interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Enhancement RFC Request for Comment; proposal for major new feature or changes.
Projects
None yet
Development

No branches or pull requests

1 participant