ParameterGenerator always fails with variadic parameters

[michalbundyra]

The ParameterGenerator always considers ReflectionParameter#isOptional() when checking for default parameter values.

A variadic argument is, though, always optional and never has a default value.

---

Originally posted by @Ocramius at zendframework/zend-code#6

[mchekin]

@michalbundyra
I would like to take care of this issue.

[mchekin]

@michalbundyra

Maybe I do not understand the issue, but according to the source code:
https://github.com/laminas/laminas-code/blob/4.1.x/src/Generator/ParameterGenerator.php#L59-L65

And according to the tests:
https://github.com/laminas/laminas-code/blob/4.1.x/test/Generator/ParameterGeneratorTest.php#L506-L556

It seems like everything works as expected.

Am I missing something here?

[Ocramius]

@mchekin the test checks ->isVariadic(), but not ->isOptional(), I think?

[mchekin]

@Ocramius
@michalbundyra

I created a pull request which prevents generating variadic parameters with default value + an accompanying unit test #72

[Ocramius]

Handled in #72