Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PSR-7 1.1/2.0 #132

Closed
weierophinney opened this issue Apr 4, 2023 · 2 comments
Closed

Update to PSR-7 1.1/2.0 #132

weierophinney opened this issue Apr 4, 2023 · 2 comments
Assignees
Milestone

Comments

@weierophinney
Copy link
Member

Feature Request

Q A
New Feature yes
RFC no
BC Break yes

Summary

PSR-7 has just released tags for 1.1 and 2.0. 1.1 adds parameter type hints, and 2.0 adds return type hints.

For our purposes, we'll need to do a new minor and a new major:

  • The new minor will bump to ^1.1 of the spec, and basically require no changes on our part. Since you can widen parameter types, we can omit them from in this release and still conform to the spec. We already provide return type hints in our implementation; again, these conform to the LSP, as you can have more specific RTH.
  • The new major will bump to ^1.1 || ^2.0, and add parameter type hints.

I've actually already done the work for these releases when I worked on the PSR-7 errata that introduced the new tags, and will get patches submitted this week.

The bigger issue will be updating all code depending on Diactoros and/or PSR-7.

@weierophinney weierophinney added this to the 3.0.0 milestone Apr 4, 2023
@weierophinney weierophinney self-assigned this Apr 4, 2023
@boesing
Copy link
Member

boesing commented Apr 4, 2023

@weierophinney
Copy link
Member Author

Resolved with #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants