Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace container-interop with PSR-11 container interface #5

Closed
weierophinney opened this issue Dec 31, 2019 · 6 comments · Fixed by #25
Closed

Replace container-interop with PSR-11 container interface #5

weierophinney opened this issue Dec 31, 2019 · 6 comments · Fixed by #25

Comments

@weierophinney
Copy link
Member

This PR replaces use of the container-interop package with the PSR-11 container interface. This is obviously a BC break and would need to be released in EventManager 4.0 along with a migration guide.

This PR is being submitted in conjunction with a similar PR on the zend-framework/zend-servicemanager repository. Before merging and releasing the zend-servicemanager PR, this one should be merged and released with a new major version, and the zend-servicemanager should have its Composer dependencies updated to include version 4.0 of zend-eventmanager.


Originally posted by @michaelmoussa at zendframework/zend-eventmanager#52

@weierophinney
Copy link
Member Author

@weierophinney rebased this one w/changes from latest develop. The migration guide in this repo is organized differently from what I already did in ServiceManager... where would you like this part documented?


Originally posted by @michaelmoussa at zendframework/zend-eventmanager#52 (comment)

@weierophinney
Copy link
Member Author

Added a fix to the existing "Replace container-interop with PSR-11" commit for the failing tests.


Originally posted by @michaelmoussa at zendframework/zend-eventmanager#52 (comment)

@SteffenAnders
Copy link

SteffenAnders commented Sep 24, 2020

what is the status here?

It would be nice to remove the

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.

message soon. :)

@weierophinney
Copy link
Member Author

@SteffenAnders It's stalled, because it snowballs out to multiple repositories. I had a plan at one time, but several reviewers called out problems with it.

We'll get there eventually; I just don't know if we'll be able to do it in the stable releases, or have to wait for BC-breaking major releases.

@jorgeribeiro
Copy link

I have just faced this problem with Lazy Listeners, because the project I am currently working uses PSR-11 container interface to inject dependencies.
Looking forward for this update

@geerteltink
Copy link
Member

geerteltink commented Oct 12, 2020

@weierophinney

It's stalled, because it snowballs out to multiple repositories. I had a plan at one time, but several reviewers called out problems with it.

We'll get there eventually; I just don't know if we'll be able to do it in the stable releases, or have to wait for BC-breaking major releases.

Can we discuss this on the next TSC meeting and find a solution for it? I was wondering myself why not go full BC break in a new major version and just remove it: Keep it simple and don't care about the current versions. I rather go with a new major release than leave this open for months or years even.

@boesing boesing linked a pull request Apr 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants