Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation must be prepared #6

Closed
froschdesign opened this issue Sep 29, 2022 · 6 comments · Fixed by #16
Closed

Documentation must be prepared #6

froschdesign opened this issue Sep 29, 2022 · 6 comments · Fixed by #16

Comments

@froschdesign
Copy link
Member

froschdesign commented Sep 29, 2022

The following topics must be covered and each must be presented on a separate page:

  • Filters
    • ToE164
    • ToInternationalPhoneNumber
    • ToNationalPhoneNumber
  • Validators
    • PhoneNumber
  • View Helpers
    • PhoneNumberFormat

The configuration with default-country-code and acceptable-number-types should be implemented in the section "Application Integration".

The content of the pages must follow the existing structure.

Examples:


Unfortunately, at the moment we do not have an operational solution to merge documentations. Therefore, the new pages will be added to the repository of laminas-i18n – temporary.
(To ensure that the topic is not forgotten, the problem is followed up in a separate issue report.)

Therefore we will use the URL snippets extension of PyMdown.

The goal is still to keep information together for the reader. At the moment, a lot is fragmented and you have to search too much or coherent explanations are missing.
(Examples: laminas-paginator and laminas-paginator-adapter-laminasdb or Mezzio and authentication)

@froschdesign
Copy link
Member Author

@gsteel
I will help here.

@Ocramius
Copy link
Member

Ocramius commented Nov 8, 2022

Ah, I suppose this is still a blocker for 1.0.0?

@froschdesign
Copy link
Member Author

@Ocramius
Correct!

@gsteel
Copy link
Member

gsteel commented Nov 8, 2022

@froschdesign
So does this mean that docs can be setup in this repo? If so, I can make a start on the docs in a new patch ASAP.

@Ocramius
Copy link
Member

Ocramius commented Nov 8, 2022

They should be maintained here, yep.

@froschdesign
Copy link
Member Author

@gsteel

So does this mean that docs can be setup in this repo?

Right, but only the content! No needed for MkDocs configuration here because the Markdown files will be inserted via the Snippets extension of the PyMdown Extensions in the documentation of laminas-i18n.

This means:

For reference see the documentation of laminas-i18n:

I recommend to use these pages as blueprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants