Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly encode content-disposition header #2

Closed
6 of 7 tasks
weierophinney opened this issue Dec 31, 2019 · 0 comments · Fixed by #31
Closed
6 of 7 tasks

Properly encode content-disposition header #2

weierophinney opened this issue Dec 31, 2019 · 0 comments · Fixed by #31

Comments

@weierophinney
Copy link
Member

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

Always use ASCII for the content-disposition header. When using UTF-8 encoding, this results in a header being set as Content-Disposition: =?utf-8?Q?inline?= which is not interpreted properly by Thunderbird nor Microsoft Exchange / Outlook. This pull request forces encoding for this header to always be ASCII, so that the header reads Content-Disposition: inline and is correctly interpreted by email clients.

Fixes: magento/magento2#25076


Originally posted by @fredden at zendframework/zend-mail#251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant