Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Updates in ServiceManager break Tests #239

Closed
schnumsel opened this issue May 19, 2023 · 1 comment · Fixed by #233
Closed

Current Updates in ServiceManager break Tests #239

schnumsel opened this issue May 19, 2023 · 1 comment · Fixed by #233
Labels
Bug Something isn't working
Milestone

Comments

@schnumsel
Copy link

Bug Report

Q A
Version(s) branch 2.23.x

Summary

When trying to create a PR for branch 2.23.x, the tests fail because of a BC break in ServiceManager 3.21.
This is because some of the tests (fixed) run on SM v3.20 and others (latest) run on SM v3.21 which are not compatible.

Current behavior

Tests executed after a PR is done fail because of this BC break.

How to reproduce

Change anything irrelevant to tests in current 2.23.x branch.

Expected behavior

Tests pass

See also

@schnumsel schnumsel added the Bug Something isn't working label May 19, 2023
@Slamdunk Slamdunk linked a pull request May 22, 2023 that will close this issue
@Slamdunk
Copy link
Contributor

Fixed in #233

@Slamdunk Slamdunk added this to the 2.23.0 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants