Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with different locales fix proposal #7

Open
weierophinney opened this issue Dec 31, 2019 · 0 comments
Open

Working with different locales fix proposal #7

weierophinney opened this issue Dec 31, 2019 · 0 comments

Comments

@weierophinney
Copy link
Member

Hello! I work on translatable route segment with 3 locales ['en' => 'en_US', 'lv' => 'lv_LV', 'ru' => 'ru_RU']. However, I need to encode lv & ru translations with rawurlencode() in php array. That is because /Zend/Router/Http/Segment.php method, which performs match against the HTTP request, do not match given url path with generated regex within translation keys loop.

So my proposal is: Encode each translated string before generating regex.

proposal


Originally posted by @freeentr at zendframework/zend-router#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant