Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ErrorHandler to ErrorHandlerMiddleware #2

Closed
weierophinney opened this issue Dec 31, 2019 · 4 comments
Closed

Renaming ErrorHandler to ErrorHandlerMiddleware #2

weierophinney opened this issue Dec 31, 2019 · 4 comments
Labels
Won't Fix This will not be worked on

Comments

@weierophinney
Copy link
Member

As already mentioned in #190, there is a naming conflict in the ErrorHandler.

I had some feedback of trainees which asked me, why the ErrorHandler ain't a RequestHandler, as its name says.
That made me think about the naming and I realized, its just because of the missing Middleware postfix.

However, I'd like to rename the ErrorHandler to ErrorHandlerMiddleware to avoid future confusions about where the difference between RequestHandlerInterface and MiddlewareInterface is.


Originally posted by @boesing at zendframework/zend-stratigility#191

@weierophinney
Copy link
Member Author

@weierophinney
Copy link
Member Author

@boesing I think there might be some references to this class in the documentation so we need update it. Other than that LGTM 👍


Originally posted by @michalbundyra at zendframework/zend-stratigility#191 (comment)

@boesing
Copy link
Member

boesing commented Jan 2, 2020

Can be closed in favor of #7

@boesing
Copy link
Member

boesing commented Oct 20, 2020

Closed as this wont be applied.

@boesing boesing closed this as completed Oct 20, 2020
@boesing boesing closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2023
@boesing boesing added Won't Fix This will not be worked on and removed Enhancement labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Won't Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants