-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming ErrorHandler to ErrorHandlerMiddleware #2
Labels
Won't Fix
This will not be worked on
Comments
/cc @weierophinney @webimpress Originally posted by @boesing at zendframework/zend-stratigility#191 (comment) |
@boesing I think there might be some references to this class in the documentation so we need update it. Other than that LGTM 👍 Originally posted by @michalbundyra at zendframework/zend-stratigility#191 (comment) |
Can be closed in favor of #7 |
Closed as this wont be applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As already mentioned in #190, there is a naming conflict in the
ErrorHandler
.I had some feedback of trainees which asked me, why the
ErrorHandler
ain't aRequestHandler
, as its name says.That made me think about the naming and I realized, its just because of the missing
Middleware
postfix.However, I'd like to rename the
ErrorHandler
toErrorHandlerMiddleware
to avoid future confusions about where the difference betweenRequestHandlerInterface
andMiddlewareInterface
is.Originally posted by @boesing at zendframework/zend-stratigility#191
The text was updated successfully, but these errors were encountered: