Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching of json assets for the new benchmarking machine web server #1193

Closed
liufengyun opened this issue Apr 28, 2021 · 2 comments
Closed

Comments

@liufengyun
Copy link
Collaborator

In scala/scala3#12242, when we have multiple tests for the same PR, the data points not shown unless we clear the cache.

It used to work for the old benchmarking machine because we published the web on github pages.

With the new machine, we publish the website locally -- we need to update the settings of the webserver so that users don't need to clear the cache.

@liufengyun
Copy link
Collaborator Author

Setting the following HTTP header in the web server will suffice:

Cache-Control: no-cache

The value no-cache will first check whether the JSON file is valid before reusing it.

Doc: https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#controlling_caching

@liufengyun liufengyun changed the title Set expire time for json assets for the new benchmarking machine web server Fix caching of json assets for the new benchmarking machine web server Apr 28, 2021
@liufengyun
Copy link
Collaborator Author

Already set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant