Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the sniproxy docker with this docker #41

Closed
adamradocz opened this issue Aug 21, 2018 · 2 comments
Closed

Merge the sniproxy docker with this docker #41

adamradocz opened this issue Aug 21, 2018 · 2 comments

Comments

@adamradocz
Copy link

Hi,

IMO this docker would be much more user friendly if it were support the HTTPS by default and wasn't required another docker container for that.

@adamradocz
Copy link
Author

I can make a PR if you want.

@mintopia
Copy link
Member

Hi,

Thanks for the suggestion. It has been considered before, but since an SNI proxy is only required for some services, and only one SNI proxy is required for all caching services, it's less efficient to include it within generic.

It's also preferable with docker containers to only have one process per container, whereas this would then have two.

For these reasons, I'm going to close this, but thanks for raising it.

Thanks,
Jessica

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants