feat: add alter columns for names and nullability #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
force-pushed
the
alter-columns
branch
from
72ea448
to
09f58fb
Compare
wjones127
force-pushed
the
alter-columns
branch
from
09f58fb
to
a3d0795
Compare
wjones127
force-pushed
the
alter-columns
branch
from
a3d0795
to
fa9fc76
Compare
westonpace
approved these changes
Feb 5, 2024
python/src/dataset.rs
Outdated
| let alterations = alterations | ||
| .iter() | ||
| .map(|obj| { | ||
| let obj = PyAny::downcast::<PyDict>(obj)?; |
There was a problem hiding this comment.
Can you not just say obj.downcast::<PyDict>()?
rust/lance/src/dataset.rs
Outdated
Comment on lines
1696
to
1697
| /// If a column has an index, it's index will be preserved or transformed to | ||
| /// the new type as part of the operation. |
There was a problem hiding this comment.
Index transformation is only future right? Once we support data type changes?
There was a problem hiding this comment.
Yeah I should remove that for now.
Comment on lines
+623
to
+630
| - "name": str, optional | ||
| The new name of the column. If not specified, the column name is | ||
| not changed. | ||
| - "nullable": bool, optional | ||
| Whether the column should be nullable. If not specified, the column | ||
| nullability is not changed. Only non-nullable columns can be changed | ||
| to nullable. Currently, you cannot change a nullable column to | ||
| non-nullable. |
There was a problem hiding this comment.
If the column is already nullable, or already has the desired name, is it a no-op or a failure? From the code it looks like a no-op correct?
There was a problem hiding this comment.
Yes, it should be a no-op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass on
alter_columns()API. This allows renaming columns and making them nullable. A future PR will allow casting the type of column.