Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a function to make Query Results returned as a list of dict #67

Closed
eddyxu opened this issue May 9, 2023 · 2 comments
Closed

Comments

@eddyxu
Copy link
Contributor

eddyxu commented May 9, 2023

Currently we only support .to_df() on the Query object.

@prrao87
Copy link
Contributor

prrao87 commented May 19, 2023

As an add-on to this, does it make sense to name the .to_df() method more explicitly such that the user knows it references pandas (for when polars is fully supported in the future)? There is already a .to_pandas() method in the table API, which I assume was named this way for this very reason. .to_df() is ambiguous for a framework that supports both pandas and polars dataframes. In the longer run, it would be awesome to use .to_arrow(), .to_pandas() or .to_polars(), for both the table and query result APIs, to keep things consistent and easy to remember.

@changhiskhan
Copy link
Contributor

we have to_list() now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants