Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to lance 0.9.11 and expose merge_insert #906

Merged
merged 5 commits into from Feb 1, 2024

Conversation

westonpace
Copy link
Contributor

This adds the python bindings requested in #870 The javascript/rust bindings will be added in a future PR.

@westonpace
Copy link
Contributor Author

Hmm, the failing doctest should be fixed in the next lance release. I corrected the order of merge_insert slightly in lancedb/lance#1892 . I'll leave in draft for now.

@westonpace westonpace marked this pull request as draft January 31, 2024 17:16
@westonpace
Copy link
Contributor Author

Hmm, the failing doctest should be fixed in the next lance release. I corrected the order of merge_insert slightly in lancedb/lance#1892 . I'll leave in draft for now.

Nevermind, there is no stable order because we are using a JOIN. I'll add a sort to the example and move this back to ready.

@westonpace westonpace marked this pull request as ready for review January 31, 2024 17:49
@westonpace westonpace merged commit d77e95a into lancedb:main Feb 1, 2024
8 checks passed
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
This adds the python bindings requested in lancedb#870 The javascript/rust
bindings will be added in a future PR.
westonpace added a commit that referenced this pull request Apr 5, 2024
This adds the python bindings requested in #870 The javascript/rust
bindings will be added in a future PR.
alexkohler pushed a commit to alexkohler/lancedb that referenced this pull request Apr 20, 2024
fix action yaml, disable debug symbol instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants