feat: add merge_insert to the node and rust APIs #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eddyxu
reviewed
Feb 2, 2024
| /// merge_insert.execute(Box::new(new_data)).await.unwrap(); | ||
| /// # }); | ||
| /// ``` | ||
| fn merge_insert(&self, on: &[&str]) -> MergeInsertBuilder; |
There was a problem hiding this comment.
why dont we just call it upsert?
There was a problem hiding this comment.
Upsert has well defined semantics and is only a subset of merge insert. Merge insert can do upsert, insert-if-not-exists and replace-range. We could create an alias that sets the appropriate configuration and runs merge insert but we talked about it a bit in slack and decided not to.
There was a problem hiding this comment.
More specifically:
Bulk Update
when_matched_update_all
Upsert
when_matched_update_all
when_not_matched_insert_all
Insert if not Exists
when_not_matched_insert_all
Replace Range
when_matched_update_all
when_not_matched_insert_all
when_not_matched_by_source_delete
There was a problem hiding this comment.
And, to be clear, we didn't invent MERGE INSERT. It's an established operation in data warehouses:
albertlockett
approved these changes
Feb 2, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
westonpace
added a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.