Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-size doesn't support c suffix (bytes) #72

Closed
tavianator opened this issue Jul 29, 2017 · 6 comments
Closed

-size doesn't support c suffix (bytes) #72

tavianator opened this issue Jul 29, 2017 · 6 comments

Comments

@tavianator
Copy link

$ echo Hello world >foo
$ find foo -size 12c
foo
$ ./toybox find foo -size 12c
find: not integer: 12c
@minghui-liu
Copy link
Contributor

This is caused by atolx() in lib/lib.c not dealing with suffix b, c or *b correctly. I am working on a patch to fix it.

@minghui-liu
Copy link
Contributor

Fixed in commit 07fc8fc

@technosaurus
Copy link

I dont see how this could have actually fixed anything. It will still always evaluate to 0. toupper on any value should never equal lower case 'd'

@tavianator
Copy link
Author

@technosaurus And that seems fixed by de28ab4

@minghui-liu
Copy link
Contributor

I think this can be closed.

@enh-google
Copy link
Collaborator

@landley - this can be closed.

@landley landley closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants