Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the kref API #20

Closed
l0kod opened this issue Jan 30, 2024 · 3 comments
Closed

Use the kref API #20

l0kod opened this issue Jan 30, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@l0kod
Copy link
Member

l0kod commented Jan 30, 2024

Landlock currently uses refcount_t types, but it would be better to use struct kref and the related helpers instead.

@l0kod l0kod added enhancement New feature or request good first issue Good for newcomers labels Jan 30, 2024
@Madhupatel08
Copy link

Hi @l0kod,
can you assign this task to me, I'm working on it, and will raise a PR by tomorrow

@l0kod
Copy link
Member Author

l0kod commented Mar 11, 2024

Hi @Madhupatel08! Looking at the consequence of using kref in the current code, I'm starting to think it may not be a good idea because it could increase code complexity for not much benefit. However, you can still send a patch with this change and we'll discuss on the mailing list with other reviewers looking at concret code. Anyway, it would still be a good first start if this is for Outreachy.

FYI, the Linux kernel doesn't work with PRs but patches sent by emails as explained in the documentation.

@l0kod
Copy link
Member Author

l0kod commented Mar 12, 2024

As discussed offline, we should spend time on other tasks such as #19 or #23 .

@l0kod l0kod closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants