Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Magento 2 recipe to Lando #1553

Closed
tylers-username opened this issue Mar 26, 2019 · 9 comments
Closed

Adding Magento 2 recipe to Lando #1553

tylers-username opened this issue Mar 26, 2019 · 9 comments
Labels
feature Requesting that Lando do something new

Comments

@tylers-username
Copy link

I'd like to open up a conversation around adding Magento 2 support to Lando and get a feel of if there is enough demand to justify it being part of the core Lando package. I've gone over in detail my opinionated version of what this might look like in Lando within this PR #1552.

Here are some of the details from said PR:

  • A Magento 2 recipe (currently locked to NGINX)
    • Redis & Database service versions are default to Magento 2.3 suggested versions
  • Additional tooling:
    • Magento Cli
    • Magerun Cli (Additional open source Magento tooling)
    • magento:env:apply tooling for configuring Magento to use Lando services
    • magento:fresh tooling for devs who want a "quick install" and "quick reset" option for new projects

Items to consider:

  • Option to disable the cache & session redis created by the recipe
    ...
  • Magento recommends using ElasticSearch 5.2. For now, this is not included in the recipe because it tends to load slowly and, in general, just piss Lando off. If this PR is of interest to the Lando team then we may have to consider how or if we deal with ElasticSearch at all.
@tylers-username tylers-username added the feature Requesting that Lando do something new label Mar 26, 2019
@stale
Copy link

stale bot commented Apr 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@stale stale bot added the stale Issue has been auto-flagged as stale label Apr 25, 2019
@tylers-username
Copy link
Author

I'd like to see this remain open just a little longer. I will not "unstale" if it "staled" again.

@stale stale bot removed the stale Issue has been auto-flagged as stale label Apr 25, 2019
@rhuffstedtler
Copy link

I'd like to see it. I appreciate the work you did with that gist you posted for getting it running on the lemp recipe, but I'm four hours into fighting with it and don't have it up yet.

@tylers-username
Copy link
Author

tylers-username commented May 23, 2019

@rhuffstedtler - Are you referring to the PR #1552? If so, I'll checkout that branch tomorrow and follow the documentation I added to see if I missed anything.

Though I only tested this on Ubuntu, the tests were passing at the time I opened the PR. There are probably issues with recent updates to Lando vs the version I developed this recipe on.

@tylers-username
Copy link
Author

tylers-username commented May 23, 2019

Ah, the gist you're referring to must be https://gist.github.com/tylerssn/48c6ec37d45a3f96da3d6549cbc67d00.

This was developed on an earlier RC - I think everything >=RC12 is intended to be much more stable. If I have some down time at work tomorrow I'll update it for you. I imagine the biggest issue is the outdated NGINX config for Lando.

Edit: the gist was refractored to a much more flexible template and made compatible with the latest Lando: improper/lando-magento2-template

@stale
Copy link

stale bot commented Jul 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@stale stale bot added the stale Issue has been auto-flagged as stale label Jul 14, 2019
@stale stale bot closed this as completed Jul 21, 2019
@tylers-username
Copy link
Author

Some interest in this expressed here: improper/lando-magento2-template#3

@pirog pirog reopened this Nov 2, 2019
@stale stale bot removed the stale Issue has been auto-flagged as stale label Nov 2, 2019
@stale
Copy link

stale bot commented Dec 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@stale stale bot added the stale Issue has been auto-flagged as stale label Dec 2, 2019
@pirog pirog removed the stale Issue has been auto-flagged as stale label Dec 2, 2019
@stale
Copy link

stale bot commented Jan 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@stale stale bot added the stale Issue has been auto-flagged as stale label Jan 2, 2020
@stale stale bot closed this as completed Jan 9, 2020
@pirog pirog removed the stale Issue has been auto-flagged as stale label Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requesting that Lando do something new
Projects
None yet
Development

No branches or pull requests

3 participants