-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Magento 2 recipe to Lando #1553
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues. |
I'd like to see this remain open just a little longer. I will not "unstale" if it "staled" again. |
I'd like to see it. I appreciate the work you did with that gist you posted for getting it running on the lemp recipe, but I'm four hours into fighting with it and don't have it up yet. |
@rhuffstedtler - Are you referring to the PR #1552? If so, I'll checkout that branch tomorrow and follow the documentation I added to see if I missed anything. Though I only tested this on Ubuntu, the tests were passing at the time I opened the PR. There are probably issues with recent updates to Lando vs the version I developed this recipe on. |
Ah, the gist you're referring to must be https://gist.github.com/tylerssn/48c6ec37d45a3f96da3d6549cbc67d00. This was developed on an earlier RC - I think everything >=RC12 is intended to be much more stable. If I have some down time at work tomorrow I'll update it for you. I imagine the biggest issue is the outdated NGINX config for Lando. Edit: the gist was refractored to a much more flexible template and made compatible with the latest Lando: improper/lando-magento2-template |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues. |
Some interest in this expressed here: improper/lando-magento2-template#3 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues. |
I'd like to open up a conversation around adding Magento 2 support to Lando and get a feel of if there is enough demand to justify it being part of the core Lando package. I've gone over in detail my opinionated version of what this might look like in Lando within this PR #1552.
Here are some of the details from said PR:
The text was updated successfully, but these errors were encountered: