Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker engine version range detection not correct #2239

Closed
rikvanderkemp opened this issue May 11, 2020 · 2 comments
Closed

Docker engine version range detection not correct #2239

rikvanderkemp opened this issue May 11, 2020 · 2 comments
Assignees
Labels
bug Something aint working right!
Milestone

Comments

@rikvanderkemp
Copy link

Tell us about your setup

What is your lando version and operating system? (note that the older your version the less likely we are to reply)

v3.0.1 on Manjaro Linux

Tell us about the command you were running

lando start

Tell us about the error you got

I don't think it has side effects, however the range detection of version numbers for the Docker Engine is not quite right. But since it does give this message it feels like it does have side effects.

The message received:

 You have version 19.03.8-ce but Lando wants something in the 18.09.3 - 19.04.0 range.
   If you have purposefully installed an unsupported version and know what you are doing
   you can probably ignore this warning. If not we recommend you use a supported version
   as this ensures we can provide the best support and stability.
   https://docs.docker.com/engine/install/

Tell us generally about your bug

This happened after package upgrades in Manjaro, it seems to use a different versioning scheme then what they used previously.

@rikvanderkemp rikvanderkemp added the bug Something aint working right! label May 11, 2020
@pirog pirog added this to the 3.0.x-2 milestone May 11, 2020
@pirog
Copy link
Sponsor Member

pirog commented May 11, 2020

@rikvanderkemp nice, i can replicate this.

Looks like its getting tripped up on the hanging -ce.

smutlord added a commit that referenced this issue May 11, 2020
@pirog
Copy link
Sponsor Member

pirog commented May 12, 2020

@rikvanderkemp alright look like ed9e9c4 was merged into master so this should be resolved in the next release

@pirog pirog closed this as completed May 12, 2020
smutlord added a commit that referenced this issue May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right!
Projects
None yet
Development

No branches or pull requests

3 participants